[Portaudio] [PATCH] to improve error handling (Debian)

Dmitry Kostjuchenko dmitrykos at iauxsoft.com
Fri Oct 15 16:26:28 EDT 2010


Hi Phil,

The other solution would be calling snd_lib_error_set_handler() with NULL in 
Pa_Terminate to unregister callback pointer from ALSA but as long as PA does 
not do anything good at all in this callback I will uncomment it and will 
leave comments why it was done as you advised.

Best regards,
Dmitry.

----- Original Message ----- 
From: "Phil Burk" <pburk at mobileer.com>
To: <portaudio at music.columbia.edu>
Sent: Friday, October 15, 2010 11:01 PM
Subject: Re: [Portaudio] [PATCH] to improve error handling (Debian)


> Hi Dmitry,
>
> > I propose that we simply do not use snd_lib_error_set_handler()
> > API at all.
>
> I agree. That is the best solution. Maybe just leave a comment that it was 
> removed and why, and that it could be added back if needed only for 
> debugging. Hopefully the comment will prevent us from repeating the same 
> mistake.
>
> Thank you,
> Phil Burk
> -------------------------------------------------
> Mobileer Inc, http://www.mobileer.com/
> 75 Pleasant Lane, San Rafael, CA, 94901 USA
> Office/Fax: +1-415-453-4320
> Mobile: +1-415-846-4370
> -------------------------------------------------
>
> On 10/15/10 11:41 AM, Dmitry Kostjuchenko wrote:
>> Hi Phil,
>>
>> I examined PA Alsa implementation and apparently PA implementation uses
>> snd_lib_error_set_handler() to set callback which does nothing, here is
>> PA code:
>>
>> static void AlsaErrorHandler(const char *file, int line, const char
>> *function, int err, const char *fmt, ...)
>> {
>> }
>>
>> I propose that we simply do not use snd_lib_error_set_handler() API at 
>> all.
>>
>> Best regards,
>> Dmitry.
>>
>> ----- Original Message ----- From: "Phil Burk" <pburk at mobileer.com>
>> To: "portaudio" <portaudio at music.columbia.edu>
>> Sent: Friday, October 15, 2010 8:00 PM
>> Subject: [Portaudio] [PATCH] to improve error handling (Debian)
>>
>>
>>> I am forwarding an email from Jari.
>>>
>>> Apparently there is a serious problem involving the setting of
>>> snd_lib_error_set_handler() in the PA Unix port. This competes with
>>> the users error handler and causes crashes because it is not cleaned up.
>>>
>>> A full bug report and patch can be found at the link below.
>>>
>>> Thanks,
>>> Phil Burk
>>>
>>> -------- Original Message --------
>>> Subject: [softsynth.com] portaudio: [PATCH] to improve error handling
>>> (Debian)
>>> Date: 15 Oct 2010 08:05:13 -0000
>>> From: jari.aalto at cante.net
>>> To: phil at softsynth.com
>>>
>>>
>>> There is a patch to improve error handling in Debianm BTS, which you
>>> can hopefully review and included to later releases:
>>>
>>> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=563192
>>>
>>> Thanks,
>>> Jari
>>>
>>>
>>>
>>> _______________________________________________
>>> Portaudio mailing list
>>> Portaudio at music.columbia.edu
>>> http://music.columbia.edu/mailman/listinfo/portaudio
>>>
>>
>> _______________________________________________
>> Portaudio mailing list
>> Portaudio at music.columbia.edu
>> http://music.columbia.edu/mailman/listinfo/portaudio
>>
>>
> _______________________________________________
> Portaudio mailing list
> Portaudio at music.columbia.edu
> http://music.columbia.edu/mailman/listinfo/portaudio
> 



More information about the Portaudio mailing list